Skip to content

Add semanticId to all list elements #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 31, 2024
Merged

Add semanticId to all list elements #583

merged 6 commits into from
May 31, 2024

Conversation

Yauhenikapl
Copy link
Contributor

@Yauhenikapl Yauhenikapl commented May 28, 2024 •
edited
Loading

Description

Add semanticId to Collection elements.

Fixes #522

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Yauhenikapl Yauhenikapl requested a review from atextor May 28, 2024 09:52
@Yauhenikapl Yauhenikapl requested a review from atextor May 28, 2024 12:12
@Yauhenikapl Yauhenikapl requested a review from BirgitBoss May 31, 2024 06:58
@Yauhenikapl Yauhenikapl merged commit b1603aa into eclipse-esmf:main May 31, 2024
4 checks passed
@Yauhenikapl Yauhenikapl deleted the 522-aasx-generation-add-semanticId-to-all-elements branch May 31, 2024 12:54
@github-actions GitHub Actions
Copy link

Release v2.8.0 addresses this.

@BirgitBoss
Copy link
Contributor

Unfortunately, there seems to be no samm-cli-2.8.0-windows-x86_64.zip offered as part of the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atextor atextor atextor approved these changes

@BirgitBoss BirgitBoss Awaiting requested review from BirgitBoss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] CLI aasx Generation - add semanticId to all elements
3 participants
@Yauhenikapl @BirgitBoss @atextor